[Chakra V3 Upgrade 🎨] Create Skip Nav Components (@W-18507873@)#2757
Merged
adamraya merged 9 commits intofeature/chakra-ui-upgrade-v3from Jul 15, 2025
Merged
[Chakra V3 Upgrade 🎨] Create Skip Nav Components (@W-18507873@)#2757adamraya merged 9 commits intofeature/chakra-ui-upgrade-v3from
adamraya merged 9 commits intofeature/chakra-ui-upgrade-v3from
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
alexvuong
reviewed
Jul 9, 2025
packages/extension-chakra-storefront/src/components/skip-nav/index.tsx
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
Jul 9, 2025
packages/extension-chakra-storefront/src/components/skip-nav/index.tsx
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
Jul 9, 2025
packages/extension-chakra-storefront/src/components/skip-nav/index.tsx
Outdated
Show resolved
Hide resolved
unandyala
approved these changes
Jul 11, 2025
packages/extension-chakra-storefront/src/components/skip-nav/index.tsx
Outdated
Show resolved
Hide resolved
packages/extension-chakra-storefront/src/components/skip-nav/index.test.tsx
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
Jul 11, 2025
|
|
||
| describe('SkipNavLink', () => { | ||
| test('renders with default props', () => { | ||
| render( |
Contributor
There was a problem hiding this comment.
Nit: Can we use renderWithProviders?
alexvuong
reviewed
Jul 11, 2025
| const styles = recipe() | ||
|
|
||
| return ( | ||
| <Box id={id} css={[styles.content, css]} tabIndex={-1} {...props}> |
Contributor
There was a problem hiding this comment.
Should this be an object speading instead of array? 🤔 First time seeing this syntax.
Suggested change
| <Box id={id} css={[styles.content, css]} tabIndex={-1} {...props}> | |
| <Box id={id} css={{...styles.content, ...css}} tabIndex={-1} {...props}> |
alexvuong
reviewed
Jul 11, 2025
| } | ||
| }, | ||
| content: { | ||
| // tabIndex needs to be set as a prop, not a style |
Contributor
There was a problem hiding this comment.
should this comment be here?
alexvuong
reviewed
Jul 11, 2025
packages/extension-chakra-storefront/src/theme/components/project/skip-nav.js
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
Jul 15, 2025
| height: 'auto !important', | ||
| overflow: 'visible !important', | ||
| zIndex: 'skipNav', | ||
| padding: '8px', |
Contributor
There was a problem hiding this comment.
Can we use padding: 2 to get the theme value?
alexvuong
reviewed
Jul 15, 2025
| textDecoration: 'none', | ||
| border: '2px solid black', | ||
| borderRadius: '4px', | ||
| fontSize: '14px', |
Contributor
There was a problem hiding this comment.
Can we use fontSize: 'sm'?
alexvuong
reviewed
Jul 15, 2025
| textDecoration: 'none', | ||
| border: '2px solid black', | ||
| borderRadius: '4px', | ||
| fontSize: '14px', |
Contributor
There was a problem hiding this comment.
Can we move it to base instead declaring same value for _focus and _focusVisible
alexvuong
approved these changes
Jul 15, 2025
alexvuong
pushed a commit
that referenced
this pull request
Jul 16, 2025
* init * Clean up styles * PR Feedback * Use zIndex value * Use zIndex default skipNav value * PR Feedback * Fix copyright year * Use token values instead of px * Move styles to base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
SkipNavLinkandSkipNavContentcomponents mimicking the equivalent Chakra UI v2@chakra-ui/skip-navpackage, which doesn't exist in Chakra UI v3.Chakra UI v2's skip nav components:
skipnav.mov
Types of Changes
Changes
How to Test-Drive This PR
template-typescript-minimaldev server:npm startEnterto reload the page and pressTab.Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization